Make sure tests pass in any culture and extract words using unicode categories#8
Open
monoblaine wants to merge 2 commits intomunyabe:masterfrom
Open
Make sure tests pass in any culture and extract words using unicode categories#8monoblaine wants to merge 2 commits intomunyabe:masterfrom
monoblaine wants to merge 2 commits intomunyabe:masterfrom
Conversation
If we don't do that, tests won't pass in a computer using Turkish locale settings because of the following reasons: In Turkish, * Upper(i) is "İ" * Upper(ı) is "I" * Lower(İ) is "i" * Lower(I) is "ı"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First of all thanks for this extension, it's really helpful. I'd like to change a few things if that's all right with you.
The first problem I saw after cloning the project was that the tests were failing because I use Turkish locale settings in my computer. Anyway, the short explanation is
Upper(i)is notIin Turkish, it's actuallyİ. More info here if you're interested. So the first modification (9f60198) I did was to useen-USculture in all existing test methods.The other modification (2c662df) is related to the word extraction algorithm. You've used
a-zcharacter ranges but this range does not include language specific letters (ş, ç, ö, ğ, ıfor Turkish) so I've changed all those character ranges with unicode categories.